[bisq-network/bisq] [WIP] Feature dark mode (#2414)

[Christoph Atteneder]

ripcurlx commented on this pull request.

I left a couple of first remarks. In general I like the new structure a lot as it makes it easier to maintain, but I still have issues getting it to run on my local setup. Compass compile is running and I have the main css and themes css in my bisq/desktop/styles dir, but it seems to have issues loading them during startup:
```
Feb. 28, 2019 5:10:50 NACHM. com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
WARNUNG: Resource "/bisq/desktop/styles/theme-light.css" not found.
Feb. 28, 2019 5:10:51 NACHM. com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
WARNUNG: Resource "/bisq/desktop/styles/bisq.css" not found.
```
No idea why it uses the german locale just for this block log outpout. I'll see if I find the issue regarding the css loading. For you it works out-of-the-box?

> @@ -281,6 +287,7 @@ configure(project(':desktop')) {
         compile project(':p2p')
         compile project(':core')
         compile project(':common')
+

No need for the extra new line.

> @@ -1292,6 +1292,7 @@ message PreferencesPayload {
     string rpc_user = 47;
     string rpc_pw = 48;
     string take_offer_selected_payment_account_id = 49;
+    bool use_dark_theme = 50;

Not sure if we should use a boolean or if we want to have it more future proof if more themes are created over time?

> @@ -25,6 +25,7 @@
 
 public class GlobalSettings {
     private static boolean useAnimations = true;
+    private static boolean useDarkTheme = false;

Is there a reason why we need it in the GlobalSettings object?

> @@ -0,0 +1,108 @@
+
+ at import "_variables.scss";

Is it necessary to import it here as well, as it is already imported in _base-colors?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2414#pullrequestreview-208492088
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190228/b94f03d5/attachment.html>