[bisq-network/bisq] List Bitmark (BTM) (#2078)

Andrew K notifications at github.com
Wed Jan 2 10:49:27 UTC 2019


Hi, for the explorer, I made some changes on a "dev" page: http://explorer.bitmark.co/index-dev.php. I am waiting for approval from someone, but it should soon be on explorer.bitmark.co. It allows for searching of txids, block hashes, or block numbers, and for txids it show the full block info (all transactions and amounts getting sent to the outputs). If you need more detailed transaction info (such as list of all inputs and values) then I can add that too.

For the code style, I looked through it and saw some properties like BLANK_LINES_BEFORE_PACKAGE and SOFT_MARGINS. But I think it satisfies it. I compared with other pull requests that were merged, and perhaps one problem is that I'm using tabs (automatic with emacs) in one place instead of spaces for indentation: https://github.com/bisq-network/bisq/pull/2078/files#diff-a500a9d38e9f89cca4fa053aab070da6R27. Is that the only issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2078#issuecomment-450833946
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190102/4242ec71/attachment.html>


More information about the bisq-github mailing list