[bisq-network/bisq] Update linux packaging process (#2190)
notifications at github.com
Fri Jan 4 09:26:17 UTC 2019
ripcurlx requested changes on this pull request.
@devinbileck Thanks for putting this PR together! I had a quick look over the changed scripts and I have following questions/remarks:
I want to prevent to create the release builds from source on every platform, as it is a time consuming process already and this would make it even slower. To be able to re-use an existing jar file it has to be placed in a similar structure as if I would have the full repository checked out. So we would also need to adapt https://github.com/bisq-network/bisq/blob/db439ce4e2386ad7258f9481480751bcfc5f9f24/desktop/package/macosx/create_app.sh#L51 Correct? Could you add this changes as well, so my release process is still working with this PR?
The advantage of having the release process now also for Linux is that it is easier for Linux dev machines to create releases. The disadvantage is, that we have to maintain both release scripts if anything changes.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the bisq-github