[bisq-network/bitcoinj] Clone transaction before adding to wallet (#18)

[Manfred Karrer]

Cloning a transaction does not clone the connected outputs from the transaction inputs. Not sure if that can become an issue here, btu maybe worth to consider.

@sqrrm Is the only use case where this leads to a problem the one when a user sends BTC from his Bisq BTC wallet to the BSQ wallet? This is not a valid use-case (not possible even as the prefix "B" in the address would not allow sending BTC. 
If that is the only use-case I would not add such a high risk change at the current point of development. Adding multi-wallet support to BitcoinJ properly might be a bigger effort and will require lots of testing. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/18#issuecomment-451698539
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190105/1503b06e/attachment.html>