[bisq-network/bitcoinj] Clone transaction before adding to wallet (#18)

[sqrrm]

@ManfredKarrer The cloning of every incoming tx will ensure that each wallet has unique txs and thus the connected outputs will be unique to that wallet. The current problem is that transactions published by the BTC side of bisq are not cloned if they're relevant to the BSQ wallet. The BSQ transactions are all cloned before being committed and then published inside WalletsManager.publishAndCommitBsqTx().

This proposed change is to make sure we do that from the BTC side as well, and we could also get rid of the explicit cloning in publishAndCommitBsqTx().

I can't think of any current use case but I don't have a complete picture of how the BTC wallet is used. It's possible that this case is the only current issue, but even if it is I think it's worth fixing to make sure we don't get trouble further down the line when we get at atomic BTC/BSQ transactions or something similar.

@oscarguindzberg Good point, better to avoid unnecessary cloning. I will make a new PR without all the reverted commits. I think we should refrain from too much refactoring right now but rather look at doing things slowly and only get this fix in if it's acceptable.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/18#issuecomment-451747357
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190106/17b01578/attachment.html>