[bisq-network/bitcoinj] Clone transaction before adding to wallet (#18)

[Manfred Karrer]

@sqrrm Ah ok, that explains why we don't encounted any issues as all BSQ txs are broadcasted by the BSQ wallet and cloned at that step. Also the trade fee txs are cloning the tx for the btc wallet.
So the only use cases are invalid ones (managing to send BTC from Bisq to the BSQ wallet outside the UI). 

I agree we should fix that even if it is not a real risk atm. But would prefer to make it at a later point to not add risk now and focus on other more concrete issues. 

@sqrrm Is it ok to close that PR?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/18#issuecomment-451755463
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190106/179e8984/attachment.html>