[bisq-network/bitcoinj] Clone transaction before committing to wallet (#21)
Oscar Guindzberg
notifications at github.com
Sun Jan 6 20:55:44 UTC 2019
oscarguindzberg commented on this pull request.
> @@ -1698,6 +1698,11 @@ public void receivePending(Transaction tx, @Nullable List<Transaction> dependenc
return;
if (isTransactionRisky(tx, dependencies) && !acceptRiskyTransactions) {
// isTransactionRisky already logged the reason.
+
+ // Clone transaction to avoid multiple wallets pointing to the same transaction. This can happen when
+ // two wallets depend on the same transaction.
+ tx = tx.getParams().getDefaultSerializer().makeTransaction(tx.bitcoinSerialize());
+
ah, you are right.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/21#discussion_r245522144
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190106/1e626a92/attachment.html>
More information about the bisq-github
mailing list