[bisq-network/bitcoinj] Clone transaction before committing to wallet (#21)

[Manfred Karrer]

@sqrrm 
I discussed the issue with @oscarguindzberg 
I think it is too risky to clone every tx at a low level. We are not clear what can be the consequences as the pointers to the connected outputs (from the inputs) are not not cloned and might cause issues at some use cases.
Another point is that conceptually a single tx shared between wallets is probably the correct design and the follow up problems should rather be fixed instead of copying txs. This all requires quite a bit of work and analysis and as long we don't have a strong use case where we run into problems I prefer to postpone that to a later point of time.
So I would suggest to close the PR.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/21#issuecomment-452110048
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190107/e9ba4f33/attachment.html>