[bisq-network/bisq] Update windows packaging process (#2163)
Devin Bileck
notifications at github.com
Tue Jan 8 00:42:18 UTC 2019
@ripcurlx The merge looks fine. However, a few comments to other commits:
- The iss file requires the BOM since it contains unicode messages. Otherwise they will not be displayed properly. See https://stackoverflow.com/a/49923030/8871018. Not sure why it doesn't work for you?
- Overriding JAVA_HOME should not be an issue, as it should be local to the script?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2163#issuecomment-452133828
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190108/d540477c/attachment-0001.html>
More information about the bisq-github
mailing list