[bisq-network/bisq] List BitDaric (DARX) (#1965)

Bernard Labno notifications at github.com
Wed Jan 9 09:43:06 UTC 2019


blabno commented on this pull request.

NACK per comments

> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Affero General Public
+ * License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+package bisq.asset.coins;
+import bisq.asset.AddressValidationResult;
+import bisq.asset.AddressValidator;
+import bisq.asset.Coin;
+public class BitDaric extends Coin {
+    public BitDaric() {
+        super("BitDaric", "DARX", new BitDaricAddressValidator());
+    }
+    public static class BitDaricAddressValidator implements AddressValidator {

Do not introduce new validator. Use RegexAddressValidator.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/1965#pullrequestreview-190641224
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190109/7f35eda7/attachment.html>


More information about the bisq-github mailing list