[bisq-network/bisq] Fix windows install custom translations (#2247)

Devin Bileck notifications at github.com
Fri Jan 11 19:16:00 UTC 2019


The Bisq.iss file must be saved using UTF-8 encoding with BOM for the unicode custom messages to be displayed properly.

For example, the v0.9.3 release on Windows 7 French has the following issues:

- Launching the installer with the application running shows the following incorrect message text:
![image](https://user-images.githubusercontent.com/603793/50862535-b6ff3200-1350-11e9-8976-af3b0c5afa4f.png)

- Observing the application within the control panel shows the following incorrect message text:
![image](https://user-images.githubusercontent.com/603793/50862873-a8fde100-1351-11e9-9865-e89b41601539.png)

Note, this issue only affects the custom messages contained within the Bisq.iss file, not the general translations within the installer.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2247

-- Commit Summary --

  * Fix windows install custom translations

-- File Changes --

    M desktop/package/windows/Bisq.iss (4)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2247.patch
https://github.com/bisq-network/bisq/pull/2247.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2247
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190111/3c9efd63/attachment.html>


More information about the bisq-github mailing list