[bisq-network/bisq] Refactor fee estimation (#2251)
Manfred Karrer
notifications at github.com
Mon Jan 14 13:37:45 UTC 2019
ManfredKarrer commented on this pull request.
> + size = Math.max(380, averageSize);
+ txFee = txFeePerByte.multiply(size);
+ log.info("Fee estimation resulted in a tx size of {} bytes.\n" +
+ "We use an average between the taker fee tx and the deposit tx (320 bytes) which results in {} bytes.\n" +
+ "The payout tx has 380 bytes, we use that as our min value. Size for fee calculation is {} bytes.\n" +
+ "The tx fee of {} Sat", estimatedTxSize, averageSize, size, txFee.value);
+ } else {
+ size = estimatedTxSize;
+ txFee = txFeePerByte.multiply(size);
+ log.info("Fee estimation resulted in a tx size of {} bytes and a tx fee of {} Sat.", size, txFee.value);
+ }
+
+ return new Tuple2<>(txFee, size);
+ }
+
+ @VisibleForTesting
Not clear what you mean. Lets discuss on a call in a bit...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2251#discussion_r247493524
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190114/b880ccda/attachment.html>
More information about the bisq-github
mailing list