[bisq-network/bisq] Propose how to integrate Monero wallet into Bisq (#1863)

Manfred Karrer notifications at github.com
Mon Jan 14 18:55:03 UTC 2019


So to sketch a v ery rough basic concept:

1. Get notification from Bisq trade domain that the deposit tx is confirmed, the UI goes to step 2 and the BTC buyer need to send the XMR. Currently thats manual. To make it automatic we need to make a rpc call to monerod with amount and receiver address. All other params (fee,...) can be left to default for the start. After the XMR is successfully sent (need notification for success from rpc lib or poll for state change) the buyer send the payment started message to the peer. That is done now ny the button click, with automated version the XMR sent success message triggers that sending. 
2. The BTC seller also gets notified once the deposit tx is confirmed and then waits  for the "payment started message". Once he received that he will check his monero wallet if he recived the correct amount. If there he clicks the button "payment received" and with that the payout will be done.
For the automated version we could even listen immediately when the trade starts for the received XMR (in some cases the payment sent message does not arrive (bugs, network connectivy or use forget to click). So as soon the seller gets notified about the receipt of the trade amount he can trigger ther payout. One issue is that he does not see the sender address. In case he expect 2 payments with exact the same trade amount he does not know which peer has sent it. Not a big problem in reality - I don't remember any case that there was that problem. But could be fixed if we include the XMR tx ID - or maybe use payment ID? - in the "payment started message".

I think that for a minimal version no UI is required. The user runs monerod or UI wallet anyway and can use that for checking txs. But of course a nice next step could be to add a basic UI for the monero wallet.

One problem is that when you send XMR mostly your balance is locked for a while. So we need to detect that case to get notified once the required wallet balance is available.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/1863#issuecomment-454118930
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190114/e77acb81/attachment.html>


More information about the bisq-github mailing list