[bisq-network/bisq] Spend unacked bsq (#2244)

[Manfred Karrer]

Here a few general comments:
- I would prefer to not add too much dependency from DAO to BitcoinJ. The btc package should ideally does not know about the DAO (I know there are some violations of that goal, but I prefer to not add new ones). So the TxParser should not be injected there. We could invert that so that BsqNode listens on BitcoinJ for new blocks and then passes those transactions to the parser.
- The UnconfirmedState is not persisted. Could that mess up the state if you close the app and restart? 
- There is no guarantee of the order we receive the block from Bitcoin Core and the tx from BitcoinJ. It can be that we complete parsing but BitcoinJ has received the tx still as unconfirmed as well the other way round that BitcoinJ gets a tx which is condisdered confirmed but we have not got it from Bitcoin Core. Not sure if that can cause issues but I fear it can and it is difficult to test and simulate. 
Another approach might be to use Bitcoin Core to request the tx by `getmempoolentry <txId>` but of course that would only work for a full DAO node.

Lets discuss all that directly, it feels quite a complex and risky thing we want to achieve here.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2244#issuecomment-454200254
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190114/c73f6785/attachment.html>