[bisq-network/bisq] Add dark mode (#2286)

Christoph Atteneder notifications at github.com
Thu Jan 31 15:13:15 UTC 2019


@peterzen Please request @ManfredKarrer to add you as contributor and I'm able to assign you to this task.
Regarding SASS, I'm not sure if we can use the traditional tooling here as well. Javafx css looks very similar from the ruleset as regular css, but there are some differences. I did find a plugin that might work with our Gradle setup and JavaFX (https://github.com/robfletcher/gradle-compass), but you wouldn't need it if you just want to assign variables.
```
.root {
    -my-variable: #444;
}
``` 
You can split up the css file in smaller chunks to make it easier to work with. For that, we either have to load them manually or we use additional tooling. I leave the decision to you as long as it works with our current setup and integrates nicely within IntelliJ without doing any manual work during development.
https://github.com/bisq-network/bisq/blob/bf948101267ac459764cb1a012fb1aeefcfc7e4d/desktop/src/main/java/bisq/desktop/app/BisqApp.java#L221-L224
Still in the end I guess we'll need to load at least two files (colors + styles) or have two different compiled files (light style, dark style) that can be switched in the preferences.

Do you have experience using SASS within JavaFX?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2286#issuecomment-459380293
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190131/ee1d409f/attachment.html>


More information about the bisq-github mailing list