[bisq-network/bisq] Add dark mode (#2286)
Peter Banik
notifications at github.com
Thu Jan 31 16:21:50 UTC 2019
I tested a number of gradle plugins - robfletcher/gradle-compass didn't quite work (issue with the maven repo) but the `anbuck/gradle-compass` fork works well in this quick PoC: https://github.com/bisq-network/bisq/compare/master...peterzen:feature-dark-mode?expand=1
While it's indeed not a major difference in terms of savings in code lines, the ability to use SASS variables and mixins help a lot in keeping duplications low and the UI consistent down the line (not just in terms of color scheme but other things like typography and UI sizing).
IntelliJ has a SASS language support plugin and a linter which makes the editing of the SCSS sources easier on the eye slightly. I'll play around more with it and see whether the cost/benefit of an extra build step makes sense or not.
I don't have previous experience with SASS/JavaFX beyond reading up on it but found some articles that recommend it for the same reason as in the traditional web dev context.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2286#issuecomment-459406716
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190131/7662ac66/attachment.html>
More information about the bisq-github
mailing list