[bisq-network/bisq] Seednode optimizations (#2501)

Florian Reimair notifications at github.com
Tue Jul 9 10:43:40 UTC 2019


freimair commented on this pull request.



> @@ -53,7 +53,6 @@ public static void main(String[] args) throws Exception {
     protected void doExecute(OptionSet options) {
         super.doExecute(options);
 
-        checkMemory(bisqEnvironment, this);

The thing is, the checkMemory routine attempts to restart the seed node and does so by doing highly specific stuff. I had my seed node run with systemd and everytime the checkMemory did its thing, I had to manually restore and restart the node. Even without systemd, the restart did not work.
Restarting a system service after it fails due to external stuff (memory in this case) is not to be implemented in the service itself. That only complicates things and hardly works on a wider range of servers.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2501#discussion_r301518495
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190709/b11315f5/attachment.html>


More information about the bisq-github mailing list