[bisq-network/bisq] standardize on one mocking lib (remove jmockit and powermock) (#3025)

Christoph Sturm notifications at github.com
Mon Jul 29 13:28:41 UTC 2019

reasons for mockito:
* I know mockito best from previous projects, so I know pretty well how to convert all tests to mockito, with jmockit I would have to read up on it.
* Mockito seems to be the most used mocking lib in java land
* Our jmockit setup is really complicated, we use 2 different jmockit versions, one in p2p and a different one in the other modules.
* Jmockit uses an javaagent which not always works so well in the IDE

last reason and for me the main reason: jmockit and powermock both have powerful static mocking methods which mockito does not have by design, and I think simpler mocking enforces better design. 

It is possible that not all these reasons are true or still true because i don't know much about jmockit, i just saw that we have a pretty complicated setup. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190729/8b875b84/attachment.html>

More information about the bisq-github mailing list