[bisq-network/bisq] BEDCOIN add (#2989)

Bernard Labno notifications at github.com
Tue Jul 30 08:07:44 UTC 2019


blabno requested changes on this pull request.

NACK please read the new asset listing guidelines and look at other accepted PRs related to new asset listing.

- missing tests
- missing entry in assets/src/main/resources/META-INF/services/bisq.asset.Asset 
- EtherAddressValidator is not meant for `Coin` subclasses.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2989#pullrequestreview-268220796
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190730/02c177ec/attachment.html>


More information about the bisq-github mailing list