[bisq-network/bisq] improve the signedwitnessservicetest (#3034)

Christoph Sturm notifications at github.com
Tue Jul 30 11:09:36 UTC 2019

Tests should contain no conditional logic (no `if`s) and be self contained (not call private methods)
that way the test is easier to read without context switches.
You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * move all init code to setUp
  * fix warnings
  * inline test method and simplify
  * make local what can be local

-- File Changes --

    M core/src/test/java/bisq/core/account/sign/SignedWitnessServiceTest.java (199)
    M p2p/src/main/java/bisq/network/p2p/storage/persistence/AppendOnlyDataStoreService.java (6)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190730/90828ae0/attachment.html>

More information about the bisq-github mailing list