[bisq-network/bisq] Support of Torv3 (#2873)

[Nicolas Dorier]

I recently added Bisq to the supported software to connect to your BTCPay hosted node.

![image](https://user-images.githubusercontent.com/3020646/59045298-c01e0c00-88ba-11e9-90b1-90c3642bf2d7.png)

I tried it today, and sadly it does not work. 

BTCPay use Tor version 3 for exposing the full node. 

Tor v2 is not adapted to connect to your own node because you want your own BTC node to whitelist any connection using the Tor address to guarantee having a connection slot available.

But if your Tor is version 2, then your address become discoverable and anybody could connect to it and DDoS you.

```
Jun-07 00:23:18.233 [JavaFX Application Thread] INFO  b.c.b.s.WalletsSetup: Socks5Proxy for bitcoinj: socks5Proxy=sampleapi.example.com:61780	Version 5 
Jun-07 00:23:18.256 [JavaFX Application Thread] INFO  o.b.c.Context: Creating bitcoinj 0.14.7.bisq.1-SNAPSHOT context. 
Jun-07 00:23:18.263 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
Jun-07 00:23:18.263 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableMessage= Invalid hostname: rtwgivvhnlsba7qy3a64vtriehljejs4zn6cg5nz5bkj5bvl47fe5pid.onion 
Jun-07 00:23:18.264 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: throwableClass= class java.lang.IllegalArgumentException 
Jun-07 00:23:18.273 [JavaFX Application Thread] ERROR b.c.s.CommonSetup: Stack trace:
java.lang.IllegalArgumentException: Invalid hostname: rtwgivvhnlsba7qy3a64vtriehljejs4zn6cg5nz5bkj5bvl47fe5pid.onion
	at org.bitcoinj.net.OnionCatConverter.onionHostToIPV6Bytes(OnionCatConverter.java:28)
	at org.bitcoinj.net.OnionCatConverter.onionHostToInetAddress(OnionCatConverter.java:46)
	at bisq.core.btc.nodes.BtcNodeConverter$Facade.onionHostToInetAddress(BtcNodeConverter.java:130)
	at bisq.core.btc.nodes.BtcNodeConverter.convertOnionHost(BtcNodeConverter.java:61)
	at bisq.core.btc.nodes.BtcNodesRepository.lambda$getOnionHosts$1(BtcNodesRepository.java:74)
```

Torv2 seems required at BitcoinJ level, but there is normally NO NEED to require it. If you have your own fork of BitcoinJ, I advise you to patch it.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2873
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190606/ee48c06d/attachment-0001.html>