[bisq-network/bisq] Add checkbox to hide extreme offers in chart (#2884)

[Christoph Atteneder]

ripcurlx requested changes on this pull request.

Please have a look at my comments.

> @@ -53,6 +53,7 @@ shared.oneOffer=offer
 shared.multipleOffers=offers
 shared.Offer=Offer
 shared.openOffers=open offers
+shared.hideExtremes=Hide extremes

Please remove the translation as well

> @@ -146,14 +147,20 @@ public OfferBookChartView(OfferBookChartViewModel model, Navigation navigation,
     public void initialize() {
         createListener();
 
+        // Header with currency combobox and checkbox to show extreme values
+        GridPane topGrid = new GridPane();

Please also remove the additional GridPane again, so we don't use more containers as necessary.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2884#pullrequestreview-252708099
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190621/fae2c429/attachment.html>