[bisq-network/bisq] Wait for initialized wallet before processing dispute msgs, fix #2914 (#2915)
Devin Bileck
notifications at github.com
Mon Jun 24 19:15:17 UTC 2019
devinbileck approved this pull request.
utACK
> @@ -266,6 +268,13 @@ private boolean isReadyForTxBroadcast() {
}
private void applyMessages() {
+ // Some messages can't be handled until all the services are properly initialized.
+ // In particular it's not possible to complete the signing of a dispute payout
+ // by an encrypted wallet until after it's been decrypted.
+ if (!servicesInitialized) {
+ return;
Just wondering if it would make more sense to put this check in tryApplyMessages? Since it appears to be the only caller of applyMessages and has an additional check.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2915#pullrequestreview-253605748
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190624/ecd588fb/attachment-0001.html>
More information about the bisq-github
mailing list