[bisq-network/bisq] Major errors happening when user tries to accept trade. (#2910)

[a123b]

@spottedmarley The error message popped up ~3 minutes before the "Your offer has been accepted" message, right? It would be interesting to know whether the portfolio gets wiped after the error message or only after the trade notification.

Quick breakdown of the log file:
- We are a maker selling BTC
- Someone tries to take the offer
- We disagree about the market price with a difference slightly above the max. allowed 1%
- Sending the `AckMessage` for the taker's `PayDepositRequest` with the error message about the price disagreement fails because the `PeerAddress` is `null`
- Taker tries taking the offer again, this time, the price difference is within tolerance and everything works as expected (deposit tx gets published)

Looking at the code that's sending the `AckMessage`, it gets the `PeerAddress` from the `Trade` object ([TradeProtocol.java#L201](https://github.com/bisq-network/bisq/blob/v1.1.2/core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java#L201)).
The problem is that the `tradingPeerNodeAddress` property of the `Trade` object is only set in [MakerProcessPayDepositRequest.java#L95](https://github.com/bisq-network/bisq/blob/v1.1.2/core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerProcessPayDepositRequest.java#L95), which is _after_ sending the `AckMessage` with the error is initiated in [MakerProcessPayDepositRequest.java#L87](https://github.com/bisq-network/bisq/blob/v1.1.2/core/src/main/java/bisq/core/trade/protocol/tasks/maker/MakerProcessPayDepositRequest.java#L87).

What I don't understand is why the portfolio is wiped after that happens... maybe it has something to do with cleanup code getting skipped because of the NPE?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/issues/2910#issuecomment-505533956
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190625/471a9ff8/attachment.html>