[bisq-network/bisq] [WIP] Don't ask for trade volume if non positive price, fix #2925 (#2926)

[a123b]

I _think_ I know what's happening:
- `TradeManager` adds trade in `handlePayDepositRequest()`
- Price disagreement leads to NullPointerException (see [my comment on #2910](https://github.com/bisq-network/bisq/issues/2910#issuecomment-505533956))
- Thus, `cleanupTradableOnFault()` never gets called in [TradeProtocol.java#L173](https://github.com/bisq-network/bisq/blob/v1.1.2/core/src/main/java/bisq/core/trade/protocol/TradeProtocol.java#L173) and the trade falsely stays in the TradeManager/Open Trades list
- On the next `handlePayDepositRequest()`, the trade gets added _again_, so we have it in the TradeManager _twice_: One correct version and one version without a price

Thoughts?
If this is correct, do you think my fix of the underlying NPE in #2928 is enough or should we ensure that whenever a trade is added to the TradeManager's `tradableList`, already existing entries with the same ID are removed first to prevent possible similar issues like this in the future?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2926#issuecomment-506949237
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190629/0129b18b/attachment.html>