[bisq-network/bisq] [WIP] Don't ask for trade volume if non positive price, fix #2925 (#2926)

Manfred Karrer notifications at github.com
Sat Jun 29 12:36:51 UTC 2019


@a123b Great finding! Would be best if you can reproduce that on a local regtest setup to verify the assuption but looks likely that this is a correct analysis. Once reproduceable it's easier to see what path is the best to fix it. The price disagreement should alreasy clean up the trade state, so I think that might be the best place to fix it. 

To strategy to fail in case if uncertainty is intentional. Better to end up in a dispute where a human arbitrator can resolve the issue than that the protocol continues and make a wrong payout.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2926#issuecomment-506953882
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190629/e258bc09/attachment.html>


More information about the bisq-github mailing list