[bisq-network/bisq] Fix offer editing for low volume offers (#2929)

a123b notifications at github.com
Sat Jun 29 15:19:20 UTC 2019


A user on the forum had problems editing an offer:
https://bisq.community/t/alt-buy-offer-not-editable/7930

For very low volume offers, it can happen that the minimum buyer security
deposit by coin value is bigger than the maximum security deposit by
percentage of trade amount.
This caused the security deposit validity check in the offer editor to fail,
making it impossible to edit these offers.
This PR fixes the problem by setting the default percentage value to
the model instead of the calculated one in this specific case.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2929

-- Commit Summary --

  * Fix offer editing for low volume offers

-- File Changes --

    M desktop/src/main/java/bisq/desktop/main/portfolio/editoffer/EditOfferDataModel.java (12)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2929.patch
https://github.com/bisq-network/bisq/pull/2929.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190629/3e504af1/attachment.html>


More information about the bisq-github mailing list