[bisq-network/bisq] Delay broadcasting of taker fee tx (#2488)

[Manfred Karrer]

To avoid the issue with lost taker fees if the take-offer attempt fails,
we delay the publishing of the taker fee tx just before the deposit tx
gets published.
The taker fee tx must not be committed to the wallet to avoid that the
wallet would require a resync in case the tx is not published.
If the tx is not committed the addresses used there are not considered
as used and that would cause issues with the address entry context
assignment for the deposit tx. To avoid those issues we need to force
the creation of new addresses used for the multisig and payout address
entries. To be sure that happens before any of the following tasks make
use of those address entries we do that already in the createTakerFee
task.
For BSQ fee tx it behaves similar but needs separate testing.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2488

-- Commit Summary --

  * Delay broadcasting of taker fee tx

-- File Changes --

    M core/src/main/java/bisq/core/btc/wallet/BtcWalletService.java (6)
    M core/src/main/java/bisq/core/btc/wallet/TradeWalletService.java (48)
    M core/src/main/java/bisq/core/offer/OpenOffer.java (3)
    M core/src/main/java/bisq/core/offer/placeoffer/tasks/CreateMakerFeeTx.java (1)
    M core/src/main/java/bisq/core/trade/protocol/BuyerAsTakerProtocol.java (2)
    M core/src/main/java/bisq/core/trade/protocol/SellerAsTakerProtocol.java (2)
    M core/src/main/java/bisq/core/trade/protocol/tasks/buyer_as_taker/BuyerAsTakerCreatesDepositTxInputs.java (7)
    M core/src/main/java/bisq/core/trade/protocol/tasks/seller_as_taker/SellerAsTakerCreatesDepositTxInputs.java (7)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/CreateTakerFeeTx.java (93)
    A core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerPublishFeeTx.java (110)
    M core/src/main/java/bisq/core/trade/protocol/tasks/taker/TakerSendPayDepositRequest.java (7)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2488.patch
https://github.com/bisq-network/bisq/pull/2488.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2488
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190301/fd5c5587/attachment-0001.html>