[bisq-network/bisq] [WIP] Feature dark mode (#2414)

[Peter Banik]

> I left a couple of first remarks. In general I like the new structure a lot as it makes it easier to maintain, but I still have issues getting it to run on my local setup. Compass compile is running and I have the main css and themes css in my bisq/desktop/styles dir, but it seems to have issues loading them during startup:
> 
> ```
> Feb. 28, 2019 5:10:50 NACHM. com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
> WARNUNG: Resource "/bisq/desktop/styles/theme-light.css" not found.
> Feb. 28, 2019 5:10:51 NACHM. com.sun.javafx.css.StyleManager loadStylesheetUnPrivileged
> WARNUNG: Resource "/bisq/desktop/styles/bisq.css" not found.
> ```
> No idea why it uses the german locale just for this block log outpout. I'll see if I find the issue regarding the css loading. For you it works out-of-the-box?

Those messages seem to indicate that the CSS files were not generated in the `compassCompile` step. Are the files there though, after the build?

I'm getting a clean build when running on a fresh system (Ubuntu 18.04) with `openjdk-11-jdk` installed, and the resulting binary starts up correctly with no CSS related error messages.  The theme switching works as well.

```
> Task :desktop:compassCompile
unsupported Java version "10", defaulting to 1.7
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.jruby.util.SecurityHelper (file:/home/peter/.gradle/caches/modules-2/files-2.1/org.jruby/jruby-complete/9.1.14.0/953b0ecf50980a4112fd0a2cd1dec1225b93c529/jruby-complete-9.1.14.0.jar) to field java.lang.reflect.Field.modifiers
WARNING: Please consider reporting this to the maintainers of org.jruby.util.SecurityHelper
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
    write build/resources/main/bisq/desktop/styles/bisq.css
    write build/resources/main/bisq/desktop/styles/theme-dark.css
    write build/resources/main/bisq/desktop/styles/theme-light.css
```

Are you running the build in an existing local copy?  Perhaps Maven is caching its dependencies and doesn't pick up the Compass dependency properly - unfortunately I'm not well versed enough with Gradle/Maven but it sounds like the problem might be there somewhere.  Could you perhaps try running the build on a clean working copy or maybe a fresh system inside Docker and see if it works that way?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2414#issuecomment-468912393
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190302/fc8b0044/attachment.html>