[bisq-network/bisq] List Veil (VEIL) (#2430)

[Bernard Labno]

blabno requested changes on this pull request.

NACK per comments

> +    public Veil() {
+        super("Veil", "VEIL", new VeilAddressValidator());
+    }
+
+    public static class VeilAddressValidator extends Base58BitcoinAddressValidator {
+
+        public VeilAddressValidator() {
+            super(new VeilParams());
+        }
+
+        @Override
+        public AddressValidationResult validate(String address) {
+            if (address.startsWith("V")) {
+                try {
+                    // Base58
+                    Address.fromBase58(getNetworkParameters(), address);

Do not expose network parameters publicly. Just call `super.validate(address)`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2430#pullrequestreview-210000389
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190303/66237d02/attachment-0001.html>