[bisq-network/bisq] Refactor capabilities and other P2P-related stuff (#2469)

Florian Reimair notifications at github.com
Thu Mar 7 10:46:01 UTC 2019


freimair commented on this pull request.



> @@ -39,47 +38,43 @@
 @Getter
 @EqualsAndHashCode(exclude = {"date"}) // failedConnectionAttempts is transient and therefore excluded anyway
 @Slf4j
-public final class Peer implements NetworkPayload, PersistablePayload, SupportedCapabilitiesListener {
+public final class Peer extends Capabilities implements NetworkPayload, PersistablePayload, SupportedCapabilitiesListener {

aggreed. but `peer.isCapabilitySupported(...)` and `connection.isCapabilitySupported(...)` feels quite right. Having them implement some sort of `HasCapabilities` interface would result in `peer.getCapabilities().isCapabilitySupported(...)` which imho is confusing.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469#discussion_r263328034
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190307/68b1e191/attachment.html>


More information about the bisq-github mailing list