[bisq-network/bisq] Refactor capabilities and other P2P-related stuff (#2469)

Florian Reimair notifications at github.com
Thu Mar 7 10:46:47 UTC 2019


freimair commented on this pull request.



> @@ -60,7 +63,10 @@ protected void doExecute(OptionSet options) {
 
     @Override
     protected void addCapabilities() {
-        Capabilities.addCapability(Capabilities.Capability.SEED_NODE.ordinal());
+        // TODO got even worse after refactoring
+        List<Integer> current = Capabilities.toIntList(Capabilities.app);
+        current.add(Capability.SEED_NODE.ordinal());
+        Capabilities.app.resetCapabilities(Capabilities.fromIntList(current));

first, there is a TODO and second, we need that kind of code exactly once. and once more for the monitor.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469#discussion_r263328353
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190307/b209648f/attachment-0001.html>


More information about the bisq-github mailing list