[bisq-network/bisq] Refactor capabilities and other P2P-related stuff (#2469)
Florian Reimair
notifications at github.com
Thu Mar 7 11:02:44 UTC 2019
freimair commented on this pull request.
> }
- // Application need to set supported capabilities at startup
- @Getter
- @Setter
- private static List<Integer> supportedCapabilities = new ArrayList<>();
+ public void resetCapabilities(Capabilities capabilities) {
+ resetCapabilities(capabilities.capabilities);
yes I thought about that but having `Set` as superclass adds all the methods as well and well, makes the whole `Capabilities` class superfluous which then results in handling capabilities like a set. I do not know if we want that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469#discussion_r263333831
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190307/810facd2/attachment.html>
More information about the bisq-github
mailing list