[bisq-network/bisq] Refactor capabilities and other P2P-related stuff (#2469)
Florian Reimair
notifications at github.com
Thu Mar 7 11:04:24 UTC 2019
freimair commented on this pull request.
> - // Sequence in the enum must not be changed (append only).
- public enum Capability {
- TRADE_STATISTICS,
- TRADE_STATISTICS_2,
- ACCOUNT_AGE_WITNESS,
- SEED_NODE,
- DAO_FULL_NODE,
- PROPOSAL,
- BLIND_VOTE,
- ACK_MSG,
- BSQ_BLOCK
+
+ /**
+ * The global set of capabilities, i.e. the capabilities if the local app.
+ */
+ public static final Capabilities app = new Capabilities();
> I would prefer a more descriptive name here. When I read Capabilities.app it was not very clear what it means.
make a suggestion
> Also does not need to be static?
yes, as it hold the capabilities of the running Bisq itself and is used in multiple places all over the code.
> Should the class extend HashSet instead of using the field capabilities - as that is basically what it holds?
see below
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469#discussion_r263334334
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190307/95afbf48/attachment.html>
More information about the bisq-github
mailing list