[bisq-network/bisq] Refactor capabilities and other P2P-related stuff (#2469)

[Florian Reimair]

freimair commented on this pull request.



>      }
 
-    // Application need to set supported capabilities at startup
-    @Getter
-    @Setter
-    private static List<Integer> supportedCapabilities = new ArrayList<>();
+    public void resetCapabilities(Capabilities capabilities) {
+        resetCapabilities(capabilities.capabilities);
+    }
+
+    public void resetCapabilities(Collection<Capability> capabilities) {

hm interesting. A `setCapabilities` seems to me clear as it replaces all capabilities, a `resetCaps` indicates more strongly, that the capabilities are going to be replaced. I would understand a  `clearCapabilities` as a clear without add.

Again, in a collection of events logs, a reset clears the log. Hm. `setCapabilities` or simply `set`?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2469#discussion_r263336246
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190307/678475a2/attachment.html>