[bisq-network/bisq] Make vote result json deterministic (#2515)
benk10
notifications at github.com
Fri Mar 8 06:32:31 UTC 2019
ben-kaufman commented on this pull request.
> });
+ cycleJson.addProperty("numberOfProposals", proposalsArray.size());
This seems to be a duplicate of `proposalsCount`. Please remove one of them.
If you keep this one, I suggest to also change the name of `votesCount` to `numberOfVotes` and make it an int to keep consistency.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2515#pullrequestreview-212154729
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190308/ee0aa00a/attachment.html>
More information about the bisq-github
mailing list