[bisq-network/bisq] Add txId to proposal display (#2519)
Christoph Atteneder
notifications at github.com
Fri Mar 8 11:33:13 UTC 2019
ripcurlx requested changes on this pull request.
NACK - Besides this one change 👍
> @@ -477,6 +486,12 @@ public void applyProposalPayload(Proposal proposal) {
linkHyperlinkWithIcon.setOnAction(e -> GUIUtil.openWebPage(proposal.getLink()));
}
+ if (txHyperlinkWithIcon != null) {
+ txHyperlinkWithIcon.setText(proposal.getTxId());
+ txHyperlinkWithIcon.setOnAction(e ->
+ GUIUtil.openWebPage("https://explorer.bisq.network/testnet/tx.html?tx=" + proposal.getTxId()));
Please use
https://github.com/bisq-network/bisq/blob/855ca062c67ca752db42cb237f0528ffec1d0b3f/desktop/src/main/java/bisq/desktop/util/GUIUtil.java#L995-L998
to open the explorer, so it also works when the DAO is live.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2519#pullrequestreview-212245119
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190308/7ce81d8c/attachment.html>
More information about the bisq-github
mailing list