[bisq-network/bisq] Fix missing balance at restore from seed words (#2517)

Manfred Karrer notifications at github.com
Sat Mar 9 03:25:12 UTC 2019


ManfredKarrer commented on this pull request.



>              persist();
         }
+
+        // We add a confidence listener to get notified about potential new transactions and
+        // add an address entry list in case it does not exist yet. This is mainly needed for restore from seed words
+        // but can help as well in case the addressEntry list would miss an address where the wallet was received
+        // funds (e.g. if the user sends funds to an address which has not been provided in the main UI - like from the
+        // wallet details window).
+        wallet.addTransactionConfidenceEventListener((w, tx) -> {

I tried the WalletCoinsReceivedEventListener and WalletCoinsSentEventListener (both) but the balance was not correct that way. I have not investigated further why, but if you could find out would be good. I am aware that the TransactionConfidenceEventListener is a bit heavy.
If you test it you need a wallet which is a bit older and has a few addresses where it has send/received. During the spv chain sync you can check if the UI balance is the same as the one from the wallet shown at the popup opened from cmd+e. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2517#discussion_r263984495
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190308/4fc347eb/attachment.html>


More information about the bisq-github mailing list