[bisq-network/bisq] Added feedback popup for DAO test users (#2521)

[Manfred Karrer]

ManfredKarrer requested changes on this pull request.



> @@ -223,6 +231,20 @@ protected void activate() {
         updateViews();
     }
 
+    private void maybeShowDAOTestingFeedbackWindow() {
+        String testingPopupKey = "daoTestingFeedbackPopup";
+        if (DontShowAgainLookup.showAgain(testingPopupKey)) {
+            UserThread.runAfter(() -> {
+                if (sortedList.size() > 0 && sortedList.stream().map(proposalsListItem -> proposalsListItem.getProposal().getTxId())

Better to use `myProposalListService.getList()' - this gives you your own proposals and test with `periodService.isTxInCorrectCycle(tx.getBlockHeight(), daoStateService.getChainHeight())` if it the proposal is in the current cycle.

> @@ -203,6 +209,8 @@ protected void activate() {
 
         sortedList.comparatorProperty().bind(tableView.comparatorProperty());
 
+        maybeShowDAOTestingFeedbackWindow();

Seems that would show the popup after the user has made a proposal. We want to show the popup only after the voting phase in case the user has created a proposal or if he has voted. Sorry that I have not been more clear in the GH issue....


>          GUIUtil.setFitToRowsForTableView(cyclesTableView, 25, 28, 2, 4);
     }
 
+    private void maybeShowDAOTestingFeedbackWindow() {
+        String testingPopupKey = "daoTestingFeedbackPopup";
+        if (DontShowAgainLookup.showAgain(testingPopupKey)) {
+            UserThread.runAfter(() -> {
+                if (sortedCycleListItemList.size() > 0 && (sortedCycleListItemList.get(0).getResultsOfCycle().getEvaluatedProposals().stream().map(EvaluatedProposal::getProposalTxId)
+                        .flatMap(key -> bsqWalletService.getWalletTransactions().stream().map(Transaction::getHashAsString)

I would prefer here also to use the DAO domain instead the BTC domain to avoid too much dependency to the wallet.
MyBlindVoteListService holds your own blind votes and with a check for the cycle you see if it is a current vote.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2521#pullrequestreview-212662714
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190310/b1750250/attachment-0001.html>