[bisq-network/bisq] Payment account support for the API (#2525)

Bernard Labno notifications at github.com
Mon Mar 11 07:11:48 UTC 2019


The only non-experimental endpoint is to get list of payment accounts so that user can retrieve account's id to use during trade.
The rest of endpoints (create, remove payment account) are marked as experimental features and are required for integration tests.
You can view, comment on, or merge this pull request online at:

  https://github.com/bisq-network/bisq/pull/2525

-- Commit Summary --

  * Payment account support for the API

-- File Changes --

    M api/src/main/java/bisq/api/http/exceptions/ExceptionMappers.java (102)
    A api/src/main/java/bisq/api/http/exceptions/ExperimentalFeatureException.java (7)
    A api/src/main/java/bisq/api/http/exceptions/NotFoundException.java (7)
    A api/src/main/java/bisq/api/http/facade/PaymentAccountFacade.java (54)
    A api/src/main/java/bisq/api/http/model/PaymentAccountList.java (11)
    A api/src/main/java/bisq/api/http/model/payment/AbstractPaymentAccountConverter.java (70)
    A api/src/main/java/bisq/api/http/model/payment/AdvancedCashPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/AdvancedCashPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/AliPayPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/AliPayPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/CashDepositPaymentAccount.java (43)
    A api/src/main/java/bisq/api/http/model/payment/CashDepositPaymentAccountConverter.java (51)
    A api/src/main/java/bisq/api/http/model/payment/ChaseQuickPayPaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/ChaseQuickPayPaymentAccountConverter.java (34)
    A api/src/main/java/bisq/api/http/model/payment/ClearXchangePaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/ClearXchangePaymentAccountConverter.java (34)
    A api/src/main/java/bisq/api/http/model/payment/CryptoCurrencyPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/CryptoCurrencyPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/F2FPaymentAccount.java (25)
    A api/src/main/java/bisq/api/http/model/payment/F2FPaymentAccountConverter.java (36)
    A api/src/main/java/bisq/api/http/model/payment/FasterPaymentsPaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/FasterPaymentsPaymentAccountConverter.java (34)
    A api/src/main/java/bisq/api/http/model/payment/HalCashPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/HalCashPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/InteracETransferPaymentAccount.java (29)
    A api/src/main/java/bisq/api/http/model/payment/InteracETransferPaymentAccountConverter.java (38)
    A api/src/main/java/bisq/api/http/model/payment/MoneyBeamPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/MoneyBeamPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/MoneyGramPaymentAccount.java (31)
    A api/src/main/java/bisq/api/http/model/payment/MoneyGramPaymentAccountConverter.java (39)
    A api/src/main/java/bisq/api/http/model/payment/NationalBankAccountPaymentAccount.java (39)
    A api/src/main/java/bisq/api/http/model/payment/NationalBankAccountPaymentAccountConverter.java (48)
    A api/src/main/java/bisq/api/http/model/payment/PaymentAccount.java (104)
    A api/src/main/java/bisq/api/http/model/payment/PaymentAccountConverter.java (13)
    A api/src/main/java/bisq/api/http/model/payment/PaymentAccountHelper.java (77)
    A api/src/main/java/bisq/api/http/model/payment/PerfectMoneyPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/PerfectMoneyPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/PopmoneyPaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/PopmoneyPaymentAccountConverter.java (35)
    A api/src/main/java/bisq/api/http/model/payment/PromptPayPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/PromptPayPaymentAccountConverter.java (32)
    A api/src/main/java/bisq/api/http/model/payment/RevolutPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/RevolutPaymentAccountConverter.java (33)
    A api/src/main/java/bisq/api/http/model/payment/SameBankAccountPaymentAccount.java (39)
    A api/src/main/java/bisq/api/http/model/payment/SameBankAccountPaymentAccountConverter.java (47)
    A api/src/main/java/bisq/api/http/model/payment/SepaInstantPaymentAccount.java (39)
    A api/src/main/java/bisq/api/http/model/payment/SepaInstantPaymentAccountConverter.java (48)
    A api/src/main/java/bisq/api/http/model/payment/SepaPaymentAccount.java (39)
    A api/src/main/java/bisq/api/http/model/payment/SepaPaymentAccountConverter.java (48)
    A api/src/main/java/bisq/api/http/model/payment/SpecificBanksAccountPaymentAccount.java (46)
    A api/src/main/java/bisq/api/http/model/payment/SpecificBanksAccountPaymentAccountConverter.java (54)
    A api/src/main/java/bisq/api/http/model/payment/SwishPaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/SwishPaymentAccountConverter.java (35)
    A api/src/main/java/bisq/api/http/model/payment/USPostalMoneyOrderPaymentAccount.java (23)
    A api/src/main/java/bisq/api/http/model/payment/USPostalMoneyOrderPaymentAccountConverter.java (34)
    A api/src/main/java/bisq/api/http/model/payment/UpholdPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/UpholdPaymentAccountConverter.java (33)
    A api/src/main/java/bisq/api/http/model/payment/WeChatPayPaymentAccount.java (20)
    A api/src/main/java/bisq/api/http/model/payment/WeChatPayPaymentAccountConverter.java (33)
    A api/src/main/java/bisq/api/http/model/payment/WesternUnionPaymentAccount.java (34)
    A api/src/main/java/bisq/api/http/model/payment/WesternUnionPaymentAccountConverter.java (42)
    A api/src/main/java/bisq/api/http/model/validation/CountryCode.java (27)
    A api/src/main/java/bisq/api/http/model/validation/CountryCodeValidator.java (20)
    A api/src/main/java/bisq/api/http/service/ExperimentalFeature.java (25)
    M api/src/main/java/bisq/api/http/service/HttpApiInterfaceV1.java (11)
    A api/src/main/java/bisq/api/http/service/ValidationErrorMessage.java (20)
    A api/src/main/java/bisq/api/http/service/endpoint/PaymentAccountEndpoint.java (88)
    A api/src/test/java/bisq/api/http/model/validation/CountryCodeValidatorTest.java (51)
    M api/src/testIntegration/java/bisq/api/http/ApiTestHelper.java (45)
    A api/src/testIntegration/java/bisq/api/http/ExperimentalFeatureIT.java (107)
    A api/src/testIntegration/java/bisq/api/http/PaymentAccountEndpointIT.java (1236)
    A core/src/main/java/bisq/core/exceptions/ValidationException.java (39)
    A core/src/main/java/bisq/core/payment/PaymentAccountManager.java (74)
    M core/src/main/java/bisq/core/payment/validation/AltCoinAddressValidator.java (12)
    M core/src/main/java/bisq/core/user/Preferences.java (2)
    A core/src/test/java/bisq/core/payment/PaymentAccountManagerTest.java (247)
    M desktop/src/main/java/bisq/desktop/main/account/content/altcoinaccounts/AltCoinAccountsDataModel.java (33)
    M desktop/src/main/java/bisq/desktop/main/account/content/fiataccounts/FiatAccountsDataModel.java (37)

-- Patch Links --

https://github.com/bisq-network/bisq/pull/2525.patch
https://github.com/bisq-network/bisq/pull/2525.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2525
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190311/50f25b79/attachment-0001.html>


More information about the bisq-github mailing list