[bisq-network/bisq] List AmityCoin (#2520)

Bernard Labno notifications at github.com
Mon Mar 11 07:19:03 UTC 2019


blabno requested changes on this pull request.

NACK invalid commit message and PR description. Read asset listing guidelines before submitting PRs.

The code looks good. Needs just a codestyle touch. 

> + *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with Bisq. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+package bisq.asset.coins;
+
+import bisq.asset.Coin;
+import bisq.asset.RegexAddressValidator;
+
+public class Amitycoin extends Coin {
+
+    public Amitycoin() {
+        super("Amitycoin", "AMIT", new RegexAddressValidator("^amit[1-9A-Za-z^OIl]{94}"));
+    }
+}

Make sure to add newlines at the end of each file.

> +        assertValidAddress("amitUnFFwApLG9btiPWRgTjRCQUj9kZjQJ8kH3ZraSsCU4yzX4AzgaoP8jkgXhp5c5jQT3idFJChAPYzA2EydJ5A4bShqrEixa");
+        assertValidAddress("amitAcVJTUZKJtYYsosMXJBQeEbt3ZV9qSvoQ1EqkvA45MRUaYWECYNKyRZ82BvLM9MPD2Gpud3DbGzGsStKnZ9x5yKVPVGJUa");
+    }
+
+    @Test
+    public void testInvalidAddresses() {
+        assertInvalidAddress("amitAcVJTUZKJtYYsosMXJBQeEbt3ZV9qSvoQ1EqkvA45MRUaYWECYNKyRZ82BvLM9MPD2Gpud3DbGzGsStKnZ9");
+        assertInvalidAddress("amitAcVJTUZKJtYYsosMXJBQeEbt3ZV9qSvoQ1EqkvA45MRUaYWECYNKyRZ82BvLM9MPD2Gpud3DbGzGsStKnZ9x5yKVPVGJUaljashfeafh");
+        assertInvalidAddress("");
+        assertInvalidAddress("amitAcVJTUZKJtYYsosMXJBQeEbt3ZV9qSvoQ1EqkvA45MRUaYWECY#RoPOWRwpsx1F");
+        assertInvalidAddress("amitAcVJTUZKJtYYsosMXJByRZ82BvLM9MPD2Gpud3DbGzGsStKnZ9x5yKVPVGJUaJbc2q4C4fWN$C4fWNLoDLDvADvpjNYdt3sdRB434UidKXimQQn");
+        assertInvalidAddress("dsfkjasd56yaSDdguaw");
+        assertInvalidAddress("KEKlulzlksadfwe");
+        assertInvalidAddress("HOleeSheetdsdjqwqwpoo3");
+    } 
+}       

Make sure to add newlines at the end of each file.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2520#pullrequestreview-212683130
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190311/6cd124e4/attachment.html>


More information about the bisq-github mailing list