[bisq-network/bisq] Fix get all bonds not returning not active bonds (#2526)

[Manfred Karrer]

ManfredKarrer requested changes on this pull request.



> @@ -530,8 +531,8 @@ public long getTotalAmountOfConfiscatedTxOutputs() {
 
 
     public List<Bond> getAllBonds() {
-        List<Bond> bonds = bondedReputationRepository.getActiveBonds();
-        bonds.addAll(bondedRolesRepository.getActiveBonds());
+        List<Bond> bonds = new ArrayList<>(bondedReputationRepository.getBonds());

Not sure if that is ok, as the ProposalDisplay class uses that as well:
` confiscateBondComboBox.setItems(FXCollections.observableArrayList(daoFacade.getAllBonds()));`
and there we want only the active bonds.

> @@ -530,8 +531,8 @@ public long getTotalAmountOfConfiscatedTxOutputs() {
 
 
     public List<Bond> getAllBonds() {
-        List<Bond> bonds = bondedReputationRepository.getActiveBonds();
-        bonds.addAll(bondedRolesRepository.getActiveBonds());
+        List<Bond> bonds = new ArrayList<>(bondedReputationRepository.getBonds());

Also used by `daoFacade.getBondByLockupTxId` which is also used in ProposalDisplay.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2526#pullrequestreview-212913792
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190311/79a04f7b/attachment.html>