[bisq-network/bisq] Fix get all bonds not returning not active bonds (#2526)

[benk10]

ben-kaufman commented on this pull request.



> @@ -530,8 +531,8 @@ public long getTotalAmountOfConfiscatedTxOutputs() {
 
 
     public List<Bond> getAllBonds() {
-        List<Bond> bonds = bondedReputationRepository.getActiveBonds();
-        bonds.addAll(bondedRolesRepository.getActiveBonds());
+        List<Bond> bonds = new ArrayList<>(bondedReputationRepository.getBonds());

Yes, but it is needed there to display also old items correctly.
For the `setItems` I'm not sure as you do want to display the link if you choose to display the proposal, but there is no reason to have such an active proposal in the first place.

Anyway, in `getBondByLockupTxId` we want also non-active bonds so it is possible to see past proposals correctly.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2526#discussion_r264327954
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190311/739dc056/attachment.html>