[bisq-network/bisq] Fix get all bonds not returning not active bonds (#2526)

sqrrm notifications at github.com
Tue Mar 12 21:13:18 UTC 2019


sqrrm commented on this pull request.



> @@ -530,8 +531,8 @@ public long getTotalAmountOfConfiscatedTxOutputs() {
 
 
     public List<Bond> getAllBonds() {
-        List<Bond> bonds = bondedReputationRepository.getActiveBonds();
-        bonds.addAll(bondedRolesRepository.getActiveBonds());
+        List<Bond> bonds = new ArrayList<>(bondedReputationRepository.getBonds());

The naming of this function is probably not right anyway, better split into getAllBonds() and getActiveBonds(). That would make clearer.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2526#discussion_r264664624
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190312/355d7a16/attachment.html>


More information about the bisq-github mailing list