[bisq-network/bisq] Misc dao improvements (#2556)

Devin Bileck notifications at github.com
Wed Mar 20 07:52:14 UTC 2019

devinbileck commented on this pull request.

>          if (proposalStateBlockChain.isEmpty() && blockHeight > genesisBlockHeight) {
             // Takes about 150 ms for dao testnet data
             long ts = System.currentTimeMillis();
             for (int i = genesisBlockHeight; i < blockHeight; i++) {
-                maybeUpdateHashChain(i);
+                hashChainUpdated = hashChainUpdated || maybeUpdateHashChain(i);

Does this not have the unintended consequence of only updating the hashchain for the first cycle? Since once maybeUpdateHashChain returns true (first block of blind vote phase), this statement will short-circuit and not call maybeUpdateHashChain for any other blocks?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190320/b49f63b0/attachment.html>

More information about the bisq-github mailing list