[bisq-network/bisq] Improve data structure, validation and performance (#2556)
Devin Bileck
notifications at github.com
Fri Mar 22 17:04:31 UTC 2019
devinbileck approved this pull request.
utACK
Overall looks fine to me. However, I am not well experienced in this area of the code and can just make general observations.
Only concern I had was regarding translations for the validation messages. I assume that is still todo and will be completed separately?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-217872411
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190322/e8cd00ce/attachment.html>
More information about the bisq-github
mailing list