[bisq-network/bitcoinj] Bisq’s bitcoinj tor/onion changes audit (#25)
Oscar Guindzberg
notifications at github.com
Fri Mar 22 17:53:57 UTC 2019
Overview
- Changes done on bisq's bitcoinj just support onion v2 addresses.
- Most of the code needed to support tor/onion services is in https://github.com/bisq-network/bisq (out of scope of this audit)
- Upstream tor support in bitcoinj was removed because it was not well maintained and caused problems and there were no volunteers to maintain it (https://github.com/bitcoinj/bitcoinj/pull/1314)
- Tor support could be re-enabled upstream by contributing changes done on bisq's bitcoinj and on https://github.com/bisq-network/bisq
- Tor support upstream could provide
- Connect to peers running behind an onion address
- Resolve DNS over tor
- Connect via tor to clearnet peers
- A mechanism to start a local tor client (orchid or another tor client)
Commit review
- https://github.com/bisq-network/bitcoinj/commit/011fe40d971631106980c28df3ed8a51e7e875f6
- No changes suggested.
- Created PR upstream https://github.com/bitcoinj/bitcoinj/pull/1741
- https://github.com/bisq-network/bitcoinj/commit/834f57a1c17758f46bddb8335f009f010c95ba41
- No changes suggested.
- Created PR upstream https://github.com/bitcoinj/bitcoinj/pull/1742
- https://github.com/bisq-network/bitcoinj/commit/0988148bbb05e1d11e718aa421855ee7629d0778
- No changes suggested.
- https://github.com/bisq-network/bitcoinj/commit/9f09a8953469bfdbf809384f1c91dab953fe284d
- See https://github.com/bisq-network/bitcoinj/pull/24
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/issues/25
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190322/65ea1079/attachment.html>
More information about the bisq-github
mailing list