[bisq-network/bitcoinj] Tor/Onion code review changes (#24)

Manfred Karrer notifications at github.com
Sat Mar 23 01:08:04 UTC 2019


ManfredKarrer commented on this pull request.

Is it possible to get rid of the dual addr / hostname fields in PeerAddress?
With OnionCatConverter.onionHostToInetAddress the onion address could be converted and then we only deal with addr in PeerAddress, no? I think hostname was also not part of the upstream branch, so to avoid to get too much changes added would make merge to upstream easier as well.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bitcoinj/pull/24#pullrequestreview-218019118
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190322/dc1d8d3e/attachment.html>


More information about the bisq-github mailing list