[bisq-network/bisq] Improve data structure, validation and performance (#2556)

[sqrrm]

sqrrm commented on this pull request.

utACK


> @@ -680,4 +685,27 @@ public double getRequiredThreshold(Proposal proposal) {
     public Coin getRequiredQuorum(Proposal proposal) {
         return proposalService.getRequiredQuorum(proposal);
     }
+
+    public long getRequiredBond(Optional<RoleProposal> roleProposal) {

I feel these functions should reside in DaoStateService for consistency. This works, most other actual work is done where it's more relevant rather than in DaoFacade itself.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2556#pullrequestreview-218080023
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190324/5d72b240/attachment.html>