[bisq-network/bisq] Improve data structure, validation and performance (#2556)

[Manfred Karrer]

ManfredKarrer commented on this pull request.



> @@ -680,4 +685,27 @@ public double getRequiredThreshold(Proposal proposal) {
     public Coin getRequiredQuorum(Proposal proposal) {
         return proposalService.getRequiredQuorum(proposal);
     }
+
+    public long getRequiredBond(Optional<RoleProposal> roleProposal) {

Hm, not sure. Proposal is another domain as DaoState so I prefer to keep it contained in ProposalService. Sure there is much overlap but DaoStateService is already huge so in doubt I prefer to keep it in ProposalService. With DaoFacade I am not sure if we should keep it mid term. Its quite boilerplate.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/bisq-network/bisq/pull/2556#discussion_r268439462
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.bisq.network/pipermail/bisq-github/attachments/20190324/c9d54f4c/attachment.html>